Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review35281 --- Ship it! Just the following minor comment. core/src/main/scala/ka

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Feb. 24, 2014, 9:59 a.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review33124 --- Ship it! I hope we can hold this off until delete topic which is cu

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review33121 --- Ship it! Ship It! - Jun Rao On Jan. 27, 2014, 9:28 p.m., Sriram

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Jan. 27, 2014, 9:28 p.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

> On Dec. 23, 2013, 7:54 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 964-965 > > > > > > I think we should use liveOrShuttingDownBrokerIds instead. Actually, my mistake.

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30829 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30761 --- Ship it! Ship It! - Neha Narkhede On Dec. 20, 2013, 7:23 p.m., S

Re: Review Request 15711: Patch for KAFKA-930

> On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 947 > > > > > > If a massive admin-triggered preferred replica election is in progress, > > thi

Re: Review Request 15711: Patch for KAFKA-930

> On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 947 > > > > > > If a massive admin-triggered preferred replica election is in progress, > > thi

Re: Review Request 15711: Patch for KAFKA-930

> On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 773 > > > > > > Currently, all admin tools depend on state changes like preferred > > replica e

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Dec. 20, 2013, 7:23 p.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Dec. 20, 2013, 7:13 p.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30236 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30149 --- Ship it! core/src/main/scala/kafka/controller/KafkaController.scal

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Dec. 10, 2013, 6:52 a.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Dec. 10, 2013, 6:51 a.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29816 --- It would also be useful to add a jmx for the count of partitions not

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29814 --- It would also be useful to add a jmx for the count of partitions not

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29606 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29597 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15711: Patch for KAFKA-930

> On Nov. 20, 2013, 6:30 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 236-239 > > > > > > I am wondering if this config is really necessary. Wouldn't it be > > simpler to always d

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29242 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15711: Patch for KAFKA-930

> On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 745-746 > > > > > > Should we always delete the admin path? Because if auto rebalance > > achie

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Nov. 21, 2013, 5:42 p.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

> On Nov. 21, 2013, 2:43 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 944 > > > > > > Any reason to not call onPreferredReplicaElection on the entire set of > > partitio

Re: Review Request 15711: Patch for KAFKA-930

> On Nov. 20, 2013, 6:30 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 745-746 > > > > > > Could we rename updateZk to sth like isTriggeredByCommandLine? > > Sriram Subrama

Re: Review Request 15711: Patch for KAFKA-930

> On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 926 > > > > > > rename to topicPartitionsNotLedByPreferredReplica? PreferredReplica cannot lead

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29240 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29207 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29203 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15711: Patch for KAFKA-930

> On Nov. 20, 2013, 6:30 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 260-261 > > > > > > Instead of delaying by 5 secs, should we just delay by > > config.leaderImbalance

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29177 --- Thanks for the patch. A few comments. core/src/main/scala/kafka/co

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Nov. 20, 2013, 1:38 a.m.) Review request for kafka. Bugs: KAFKA-930

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Nov. 20, 2013, 1:37 a.m.) Review request for kafka. Bugs: KAFKA-930

Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- Review request for kafka. Bugs: KAFKA-930 https://issues.apache.org/jira/br