> On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 745-746 > > <https://reviews.apache.org/r/15711/diff/3/?file=388714#file388714line745> > > > > Should we always delete the admin path? Because if auto rebalance > > achieved leader balance, then the manual rebalance has no work to do > > anyways.
This is for backwards compatibility. > On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 918 > > <https://reviews.apache.org/r/15711/diff/3/?file=388714#file388714line918> > > > > rename to allReplicasForTopicPartitionsPerBroker? (I saw the per > > convention used somewhere else) variables should be named based on the context. Here we refer to preferred replicas > On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 946 > > <https://reviews.apache.org/r/15711/diff/3/?file=388714#file388714line946> > > > > we should be able to pass the entire set of partitions in one call, > > right? see answer for Joel's comment > On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 236-239 > > <https://reviews.apache.org/r/15711/diff/3/?file=388715#file388715line236> > > > > Will it be simpler to have a per cluster config instead of a per broker > > config? i cant think of any downsides. per cluster config does not make much sense because it does not tell you about how well a broker needs to be balanced. balancing is per broker. - Sriram ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29207 ----------------------------------------------------------- On Nov. 21, 2013, 5:42 p.m., Sriram Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15711/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 5:42 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-930 > https://issues.apache.org/jira/browse/KAFKA-930 > > > Repository: kafka > > > Description > ------- > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > > commit missing code > > > some more changes > > > fix merge conflicts > > > Add auto leader rebalance support > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > Conflicts: > core/src/main/scala/kafka/admin/AdminUtils.scala > core/src/main/scala/kafka/admin/TopicCommand.scala > > change comments > > > commit the remaining changes > > > Move AddPartitions into TopicCommand > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3 > core/src/main/scala/kafka/server/KafkaConfig.scala > b324344d0a383398db8bfe2cbeec2c1378fe13c9 > > Diff: https://reviews.apache.org/r/15711/diff/ > > > Testing > ------- > > > Thanks, > > Sriram Subramanian > >
