Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

2013-12-02 Thread Neha Narkhede
> On Nov. 19, 2013, 6:40 p.m., Jay Kreps wrote: > > What happens if I am doing a read or write concurrently with a delete? > > > > Would it be simpler just to have the delete log work like the segment > > delete where rather than trying to lock we remove it from the segment list > > and then j

Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

2013-11-19 Thread Jun Rao
> On Nov. 19, 2013, 6:40 p.m., Jay Kreps wrote: > > What happens if I am doing a read or write concurrently with a delete? > > > > Would it be simpler just to have the delete log work like the segment > > delete where rather than trying to lock we remove it from the segment list > > and then j

Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

2013-11-19 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review29123 --- What happens if I am doing a read or write concurrently with a delet

Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

2013-11-19 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review29118 --- core/src/main/scala/kafka/log/LogSegment.scala

Review Request 15674: Reassign partitions should delete the old replicas from disk

2013-11-19 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/ --- Review request for kafka. Bugs: KAFKA-1074 https://issues.apache.org/jira/b