Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
> On Nov. 1, 2013, 1:03 a.m., Swapnil Ghike wrote: > > core/src/test/scala/unit/kafka/log/LogTest.scala, line 631 > > > > > > probably don't need this statement. We need to define recoveryPoint as a var here, but you'

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27956 --- Ship it! Ship It! core/src/main/scala/kafka/log/Log.scala

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27989 --- Ship it! Ship It! - Swapnil Ghike On Oct. 31, 2013, 10:28 p.m.,

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27988 --- core/src/test/scala/unit/kafka/log/LogTest.scala

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
> On Oct. 31, 2013, 10:25 p.m., Guozhang Wang wrote: > > Ship It! Thanks for the review, Guozhang! - Neha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27969 --

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/ --- (Updated Oct. 31, 2013, 10:28 p.m.) Review request for kafka and Jay Kreps. B

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/#review27969 --- Ship it! Ship It! - Guozhang Wang On Oct. 31, 2013, 10:22 p.m.,

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/ --- (Updated Oct. 31, 2013, 10:22 p.m.) Review request for kafka and Jay Kreps. B

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/ --- (Updated Oct. 31, 2013, 10:18 p.m.) Review request for kafka and Jay Kreps. B

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/ --- (Updated Oct. 31, 2013, 5:54 p.m.) Review request for kafka and Jay Kreps. Bu

Re: Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/ --- (Updated Oct. 31, 2013, 5:27 p.m.) Review request for kafka and Jay Kreps. Bu

Review Request 15137: Patch for KAFKA-1107

2013-10-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15137/ --- Review request for kafka. Bugs: KAFKA-1107 https://issues.apache.org/jira/b