Re: Review Request 14865: Patch for KAFKA-1097

2013-11-01 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review28030 --- Ship it! Ship It! - Guozhang Wang On Nov. 1, 2013, 4:55 p.m., Ne

Re: Review Request 14865: Patch for KAFKA-1097

2013-11-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review28020 --- Ship it! - Jun Rao On Nov. 1, 2013, 4:55 p.m., Neha Narkhede wrot

Re: Review Request 14865: Patch for KAFKA-1097

2013-11-01 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/ --- (Updated Nov. 1, 2013, 4:55 p.m.) Review request for kafka. Bugs: KAFKA-1097

Re: Review Request 14865: Patch for KAFKA-1097

2013-11-01 Thread Neha Narkhede
> On Nov. 1, 2013, 4:33 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 397-398 > > > > > > newReplicas really means the extra replicas in the reassigned replicas. > > So, we

Re: Review Request 14865: Patch for KAFKA-1097

2013-11-01 Thread Neha Narkhede
> On Nov. 1, 2013, 4:33 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 383-387 > > > > > > In moveReassignedPartitionLeaderIfRequired(), we call > > partitionStateMachine.ha

Re: Review Request 14865: Patch for KAFKA-1097

2013-11-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review28011 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-31 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/ --- (Updated Oct. 31, 2013, 5:37 p.m.) Review request for kafka. Bugs: KAFKA-1097

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-31 Thread Neha Narkhede
> On Oct. 31, 2013, 3:44 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 310 > > > > > > One thing worth mention here is that previously we are printing > > TopicAndPartition

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review27902 --- Ship it! core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-30 Thread Neha Narkhede
> On Oct. 29, 2013, 9:12 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 163 > > > > > > Also add "// add replicas that are new" Done > On Oct. 29, 2013, 9:12 p.m., Guozhang Wa

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-30 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/ --- (Updated Oct. 31, 2013, 4:46 a.m.) Review request for kafka. Bugs: KAFKA-1097

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-30 Thread Neha Narkhede
> On Oct. 30, 2013, 5:12 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 397-398 > > > > > > Should we name this addedReplicas? To me, new and old replicas mean the > > set o

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-30 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review27787 --- Thanks for the patch. Could you rebase? core/src/main/scala/kafka/

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review27724 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review27702 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/ --- (Updated Oct. 29, 2013, 5:49 p.m.) Review request for kafka. Bugs: KAFKA-1097

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-24 Thread Neha Narkhede
> On Oct. 24, 2013, 12:30 a.m., Guozhang Wang wrote: > > kafka-patch-review.py, line 100 > > > > > > Should this be included in this RB? Actually I wanted to improve the tool to print the branch against which the rb

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-24 Thread Neha Narkhede
> On Oct. 24, 2013, 4:30 p.m., Jun Rao wrote: > > Thanks for the patch. There a couple of issues. > > > > 1. The main one is during the phase of partition reassignment when we > > bootstrap new replicas. At this point, the assigned replica list doesn't > > include the new replicas. If we only

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-24 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review27459 --- Thanks for the patch. There a couple of issues. 1. The main one is

Re: Review Request 14865: Patch for KAFKA-1097

2013-10-23 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review27433 --- core/src/main/scala/kafka/cluster/Partition.scala

Review Request 14865: Patch for KAFKA-1097

2013-10-22 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/ --- Review request for kafka. Bugs: KAFKA-1097 https://issues.apache.org/jira/b