Re: Review Request 14497: Patch for KAFKA-1075

2013-10-07 Thread Guozhang Wang
> On Oct. 6, 2013, 4:29 p.m., Jun Rao wrote: > > With the new change, will a rebalance be triggered on a consumer when > > #partitions is changed on a consumed topic? Yes, and it is tested through the add-partitions tool. - Guozhang --

Re: Review Request 14497: Patch for KAFKA-1075

2013-10-07 Thread Guozhang Wang
> On Oct. 7, 2013, 5 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 319 > > > > > > This comment is a bit misleading. The data change watch for the > > /b

Re: Review Request 14497: Patch for KAFKA-1075

2013-10-07 Thread Guozhang Wang
> On Oct. 7, 2013, 5 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 319 > > > > > > This comment is a bit misleading. The data change watch for the > > /b

Re: Review Request 14497: Patch for KAFKA-1075

2013-10-07 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14497/#review26705 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala

Re: Review Request 14497: Patch for KAFKA-1075

2013-10-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14497/#review26712 --- With the new change, will a rebalance be triggered on a consumer whe

Review Request 14497: Patch for KAFKA-1075

2013-10-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14497/ --- Review request for kafka. Bugs: KAFKA-1075 https://issues.apache.org/jira/b