-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14497/#review26705
-----------------------------------------------------------



core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
<https://reviews.apache.org/r/14497/#comment52044>

    This comment is a bit misleading. The data change watch for the 
/brokers/topics path is only set in reinitializeConsumer() which is invoked on 
startup and when new topics are discovered through wildcards. Doesn't zkclient 
automatically re-register watches once they are fired ?



core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
<https://reviews.apache.org/r/14497/#comment52014>

    this comment is a little misleading. This just creates the listener, 
doesn't register anything yet



core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
<https://reviews.apache.org/r/14497/#comment52013>

    this comment is a little misleading. This just creates the listener, 
doesn't register anything yet


- Neha Narkhede


On Oct. 4, 2013, 10:23 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14497/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 10:23 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1075
>     https://issues.apache.org/jira/browse/KAFKA-1075
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1075.v1
> 
> 
> Diffs
> -----
> 
>   config/tools-log4j.properties 79240490149835656e2a013a9702c5aa41c104f1 
>   core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
> 08b4b7218f62f876eb95628bd6db78c0956c7f04 
> 
> Diff: https://reviews.apache.org/r/14497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Reply via email to