Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-13 Thread Guozhang Wang
> On Sept. 10, 2013, 9:46 p.m., Joel Koshy wrote: > > Following up on the performance concerns that Neha had raised - this will > > be a significant bottleneck for tools such as the mirror-maker as the > > rebalance latency will almost certainly multiply. > > > > We could consider utilizing th

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-10 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26022 --- Following up on the performance concerns that Neha had raised - this

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-10 Thread Guozhang Wang
> On Sept. 10, 2013, 6:52 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/client/ClientUtils.scala, lines 97-116 > > > > > > You can reuse ZkUtils.getPartitionAssignmentForTopics instead of > > writing a new f

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/ --- (Updated Sept. 10, 2013, 6:29 p.m.) Review request for kafka. Changes ---

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/ --- (Updated Sept. 10, 2013, 6:28 p.m.) Review request for kafka. Bugs: KAFKA-103

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-09 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26012 --- core/src/main/scala/kafka/client/ClientUtils.scala

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-09 Thread Guozhang Wang
> On Sept. 9, 2013, 11:44 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/client/ClientUtils.scala, line 100 > > > > > > The concern I have with this change is the potential performance hit to > > the consume

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26005 --- core/src/main/scala/kafka/client/ClientUtils.scala

Re: Review Request 14041: MetadataResponse during Consumer's Rebalance Process maybe Stale

2013-09-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/ --- (Updated Sept. 9, 2013, 9:31 p.m.) Review request for kafka. Summary (updated