> On Sept. 10, 2013, 6:52 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/client/ClientUtils.scala, lines 97-116 > > <https://reviews.apache.org/r/14041/diff/2/?file=349971#file349971line97> > > > > You can reuse ZkUtils.getPartitionAssignmentForTopics instead of > > writing a new function.
Yeah exactly! Thanks Swapnil. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14041/#review26012 ----------------------------------------------------------- On Sept. 10, 2013, 6:29 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14041/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 6:29 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1030 > https://issues.apache.org/jira/browse/KAFKA-1030 > > > Repository: kafka > > > Description > ------- > > Using the approach of reading directly from ZK. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > e7a692a1d23ca5a9ecf86e3cb34be418b9c0c943 > > Diff: https://reviews.apache.org/r/14041/diff/ > > > Testing > ------- > > unit tests > > > Thanks, > > Guozhang Wang > >
