Re: Should InvalidTopicException be called IllegalTopicException

2017-02-17 Thread Colin McCabe
Hmm. I'm not sure that "illegal" is that different from "invalid" semantically. If an argument is illegal for a given function, you could also say that argument is invalid for that function. Also, changing exception names could be frustrating to users from a compatibility perspective. Perhaps s

Re: Should InvalidTopicException be called IllegalTopicException

2017-02-16 Thread Cosmin Lehene
Wow, I managed to send two incomplete messages thanks to the new mac touchbar :) I was suggesting either renaming to IllegalTopicException or have a one that clearly mentions the name InvalidTopicNameException. However I guess the first option would be the easiest. Thanks, Cosmin _