Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92327 --- Ship it! Ship It! - Grant Henke On July 20, 2015, 9:48 p.m., Gra

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/ --- (Updated July 20, 2015, 9:48 p.m.) Review request for kafka. Bugs: KAFKA-2337

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92323 --- Ship it! LGTM. Just a small nit. core/src/main/scala/kafka/admin

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92296 --- Ship it! Ship It! - Ashish Singh On July 20, 2015, 5:37 p.m., Gr

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92282 --- Ship it! Ship It! - Edward Ribeiro On Julho 20, 2015, 5:37 p.m.,

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/ --- (Updated July 20, 2015, 5:37 p.m.) Review request for kafka. Bugs: KAFKA-2337

Re: Review Request 36570: Patch for KAFKA-2337

> On July 20, 2015, 5:27 p.m., Ashish Singh wrote: > > LGTM, just a small comment. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92276

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92276 --- core/src/main/scala/kafka/admin/TopicCommand.scala (line 89)

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/ --- (Updated July 17, 2015, 4:17 p.m.) Review request for kafka. Bugs: KAFKA-2337

Re: Review Request 36570: Patch for KAFKA-2337

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/common/Topic.scala, line 64 > > > > > > *Maybe* this method name could be renamed to 'collide' to make it more > > like a verb instea

Re: Review Request 36570: Patch for KAFKA-2337

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/common/Topic.scala, line 64 > > > > > > *Maybe* this method name could be renamed to 'collide' to make it more > > like a verb instea

Re: Review Request 36570: Patch for KAFKA-2337

> On July 17, 2015, 4:05 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/common/Topic.scala, lines 53-54 > > > > > > This method name is sort of a misnomer is a it is checking for special > > characters tha

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92092 --- core/src/main/scala/kafka/common/Topic.scala (lines 53 - 54)

Re: Review Request 36570: Patch for KAFKA-2337

> On July 17, 2015, 4:01 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/common/Topic.scala, line 64 > > > > > > *Maybe* this method name could be renamed to 'collide' to make it more > > like a verb instea

Re: Review Request 36570: Patch for KAFKA-2337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92089 --- core/src/main/scala/kafka/common/Topic.scala (line 64)