> On July 17, 2015, 4:05 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/common/Topic.scala, lines 53-54 > > <https://reviews.apache.org/r/36570/diff/1/?file=1014515#file1014515line53> > > > > This method name is sort of a misnomer is a it is checking for special > > characters that could lead to a collision, so *I* would suggest to rename > > it to ''hasCollisionChars'' or something like that. Or instead of > > ''couldCollide'' put it as ''maybeCollide'' as we use elswhere (e.g.: > > maybeFlushAndCommitOffsets, maybeLock, maybeComputeNext, etc).
I agree hasCollisionChars is more descriptive of the behavior. I will update. - Grant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36570/#review92092 ----------------------------------------------------------- On July 17, 2015, 3:27 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36570/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 3:27 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2337 > https://issues.apache.org/jira/browse/KAFKA-2337 > > > Repository: kafka > > > Description > ------- > > KAFKA-2337: Verify that metric names will not collide when creating new topics > > > Diffs > ----- > > core/src/main/scala/kafka/admin/AdminUtils.scala > f06edf41c732a7b794e496d0048b0ce6f897e72b > core/src/main/scala/kafka/admin/TopicCommand.scala > a90aa8787ff21b963765a547980154363c1c93c6 > core/src/main/scala/kafka/common/Topic.scala > 32595d6fe432141119db26d3b5ebe229aac40805 > core/src/test/scala/unit/kafka/admin/AdminTest.scala > 252ac813c8df1780c2dc5fa9e698fb43bb6d5cf8 > core/src/test/scala/unit/kafka/common/TopicTest.scala > 79532c89c41572ba953c4dc3319a05354927e961 > > Diff: https://reviews.apache.org/r/36570/diff/ > > > Testing > ------- > > > Thanks, > > Grant Henke > >
