Re: Review Request 35880: Patch for KAFKA-2295

2015-08-20 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/ --- (Updated Aug. 20, 2015, 12:17 p.m.) Review request for kafka. Bugs: KAFKA-229

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review91337 --- Ship it! Ship It! - Guozhang Wang On July 6, 2015, 6:05 a.m., Ma

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-10 Thread Guozhang Wang
> On July 6, 2015, 3:50 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/utils/CoreUtils.scala, line 221 > > > > > > Can we use scala's Utils.createObject here? > > Manikumar Reddy O wrote: > Are you suges

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-10 Thread Manikumar Reddy O
> On July 6, 2015, 3:50 p.m., Guozhang Wang wrote: > > clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java, > > line 57 > > > > > > Is this intentional? yes. Now ClassNotFoundException will be

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review90488 --- clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-05 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/ --- (Updated July 6, 2015, 6:05 a.m.) Review request for kafka. Bugs: KAFKA-2295

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-05 Thread Guozhang Wang
> On July 3, 2015, 1:46 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/utils/Utils.java, line 496 > > > > > > How about add a createObject function in Utils.java like > > coreUtils.scala

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-04 Thread Manikumar Reddy O
> On July 3, 2015, 1:46 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/utils/Utils.java, line 512 > > > > > > I think thread.getContextClassLoader() will never return null: > > > >

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-02 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review90305 --- clients/src/main/java/org/apache/kafka/common/utils/Utils.java (lin

Re: Review Request 35880: Patch for KAFKA-2295

2015-06-25 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/ --- (Updated June 25, 2015, 4:25 p.m.) Review request for kafka. Bugs: KAFKA-2295