----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35880/#review90305 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/utils/Utils.java (line 496) <https://reviews.apache.org/r/35880/#comment143323> How about add a createObject function in Utils.java like coreUtils.scala and let other java code calls it? clients/src/main/java/org/apache/kafka/common/utils/Utils.java (line 512) <https://reviews.apache.org/r/35880/#comment143322> I think thread.getContextClassLoader() will never return null: http://docs.oracle.com/javase/7/docs/api/java/lang/Thread.html#getContextClassLoader() - Guozhang Wang On June 25, 2015, 4:25 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35880/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 4:25 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2295 > https://issues.apache.org/jira/browse/KAFKA-2295 > > > Repository: kafka > > > Description > ------- > > Implemented the approach given in JIRA description. This is to support > dynamically loaded envirornments > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java > bae528d31516679bed88ee61b408f209f185a8cc > clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java > 4170bcc7def5b50d8aa20e8e84089c35b705b527 > clients/src/main/java/org/apache/kafka/common/utils/Utils.java > af9993cf9b3991f1e61e1201c94e19bc1bf76a68 > core/src/main/scala/kafka/utils/CoreUtils.scala > 168a18d380c200ee566eccb6988dd1ae85ed5b09 > > Diff: https://reviews.apache.org/r/35880/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
