Re: Review Request 35503: Patch for KAFKA-2012

2015-06-19 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/ --- (Updated June 19, 2015, 3:42 p.m.) Review request for kafka. Bugs: KAFKA-2012

Re: Review Request 35503: Patch for KAFKA-2012

2015-06-19 Thread Manikumar Reddy O
> On June 19, 2015, 12:11 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 225-227 > > > > > > Do we still need this now that we have verified the index consistency > > earlier? Yes, we can rem

Re: Review Request 35503: Patch for KAFKA-2012

2015-06-19 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/ --- (Updated June 19, 2015, 1:27 p.m.) Review request for kafka. Bugs: KAFKA-2012

Re: Review Request 35503: Patch for KAFKA-2012

2015-06-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35503/#review88470 --- Thanks for the patch. A couple of comments below. core/src/main/sc