Re: Review Request 32434: Patch for KAFKA-2042

2015-03-24 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434/#review77675 --- Ship it! Ship It! - Guozhang Wang On March 24, 2015, 8:57 p.m.,

Re: Review Request 32434: Patch for KAFKA-2042

2015-03-24 Thread Jiangjie Qin
> On March 24, 2015, 9:21 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/Metadata.java, line 139 > > > > > > Rename to containsTopic() for Java naming consistency? If you do not > > feel

Re: Review Request 32434: Patch for KAFKA-2042

2015-03-24 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434/#review77653 --- clients/src/main/java/org/apache/kafka/clients/Metadata.java

Re: Review Request 32434: Patch for KAFKA-2042

2015-03-24 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434/ --- (Updated March 24, 2015, 8:57 p.m.) Review request for kafka. Bugs: KAFKA-204

Re: Review Request 32434: Patch for KAFKA-2042

2015-03-24 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434/ --- (Updated March 24, 2015, 8:37 p.m.) Review request for kafka. Bugs: KAFKA-204

Re: Review Request 32434: Patch for KAFKA-2042

2015-03-24 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434/#review77634 --- As discussed offline, I think it is better to make the fix in the ap