> On March 24, 2015, 9:21 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/Metadata.java, line 139 > > <https://reviews.apache.org/r/32434/diff/3/?file=904675#file904675line139> > > > > Rename to containsTopic() for Java naming consistency? If you do not > > feel strongly about this I can do the change upon checkin.
Thanks for the review, Guozhang. Yes, I'm fine with containsTopic(). - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434/#review77653 ----------------------------------------------------------- On March 24, 2015, 8:57 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32434/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 8:57 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2042 > https://issues.apache.org/jira/browse/KAFKA-2042 > > > Repository: kafka > > > Description > ------- > > Move the change to KafkaProducer after talking to Guozhang offline. > > > A less expensive fix > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/Metadata.java > c8bde8b732defa20819730d87303a9a80d01116f > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > feda9c922d7dab17e424f8e6f0aa0a3f968e3729 > > Diff: https://reviews.apache.org/r/32434/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
