Re: Review Request 30321: Patch for kafka-1902

2015-01-28 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review70031 --- Ship it! core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

Re: Review Request 30321: Patch for kafka-1902

2015-01-28 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/ --- (Updated Jan. 28, 2015, 5:23 p.m.) Review request for kafka. Bugs: kafka-1902

Re: Review Request 30321: Patch for kafka-1902

2015-01-28 Thread Eric Olander
> On Jan. 28, 2015, 2:34 a.m., Eric Olander wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 66 > > > > > > val scope = tagsName.map {t => nameBuilder.append(",").append(t)}.orNull > > Eric Ol

Re: Review Request 30321: Patch for kafka-1902

2015-01-28 Thread Eric Olander
> On Jan. 28, 2015, 2:34 a.m., Eric Olander wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 66 > > > > > > val scope = tagsName.map {t => nameBuilder.append(",").append(t)}.orNull Sorry - I h

Re: Review Request 30321: Patch for kafka-1902

2015-01-27 Thread Eric Olander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69940 --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

Re: Review Request 30321: Patch for kafka-1902

2015-01-27 Thread Jun Rao
> On Jan. 27, 2015, 4:44 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 69 > > > > > > Seems when yammer creates the mBeanName, it will use append ",scope=" > > before sc

Re: Review Request 30321: Patch for kafka-1902

2015-01-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69814 --- core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala

Re: Review Request 30321: Patch for kafka-1902

2015-01-27 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69813 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 27, 2015, 4:16 p.m