----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review70031 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala <https://reviews.apache.org/r/30321/#comment114962> I thought the earlier idiom was better - i.e., option.map{...} core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala <https://reviews.apache.org/r/30321/#comment114963> can be on same line? core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala <https://reviews.apache.org/r/30321/#comment114965> since some reporters (such as graphite) I don't think jmx reporter cares about dot (or does it?) - Joel Koshy On Jan. 28, 2015, 5:23 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30321/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 5:23 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1902 > https://issues.apache.org/jira/browse/kafka-1902 > > > Repository: kafka > > > Description > ------- > > replace dot with $ in scope > > > use the dot convention in scope > > > Diffs > ----- > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala > e9e49180f6de45f98e79374f519f6097b4fc8637 > > Diff: https://reviews.apache.org/r/30321/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
