Re: Review Request 29893: KAFKA-1856: Add PreCommit Patch Testing

2015-01-18 Thread Ashish Singh
> On Jan. 17, 2015, 1:48 a.m., Gwen Shapira wrote: > > dev-utils/test-patch.py, lines 144-145 > > > > > > Can you validate that the hack is still needed? I'm concerned that we > > are dragging an old hack around that

Re: Review Request 29893: KAFKA-1856: Add PreCommit Patch Testing

2015-01-16 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29893/#review68534 --- Awesome script. Very nicely structured and very readable. I left few