----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29893/#review68534 -----------------------------------------------------------
Awesome script. Very nicely structured and very readable. I left few comments in the JIRA and few here. dev-utils/test-patch.py <https://reviews.apache.org/r/29893/#comment112835> Can you validate that the hack is still needed? I'm concerned that we are dragging an old hack around that perhaps was fixed years ago... dev-utils/test-patch.py <https://reviews.apache.org/r/29893/#comment112836> Where do these errors end up? will we see them in the JIRA? or in Jenkins? - Gwen Shapira On Jan. 14, 2015, 7:22 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29893/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 7:22 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1856 > https://issues.apache.org/jira/browse/KAFKA-1856 > > > Repository: kafka > > > Description > ------- > > KAFKA-1856: Add PreCommit Patch Testing > > > Diffs > ----- > > dev-utils/test-patch.py PRE-CREATION > > Diff: https://reviews.apache.org/r/29893/diff/ > > > Testing > ------- > > Tested on KAFKA-1664, > https://issues.apache.org/jira/browse/KAFKA-1664?focusedCommentId=14277439&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14277439 > > How to run: > python dev-utils/test-patch.py --defect KAFKA-1664 --username <user_name> > --password <password> --run-tests --post-results > > > Thanks, > > Ashish Singh > >
