Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/#review56827 --- Ship it! Ship It! - Joel Koshy On Oct. 15, 2014, 9:47 p.m., Ewen

Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/ --- (Updated Oct. 15, 2014, 9:47 p.m.) Review request for kafka. Bugs: KAFKA-1637

Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/#review56802 --- Ship it! Minor naming comment which we can take care of on check-in

Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/ --- (Updated Oct. 15, 2014, 4:08 p.m.) Review request for kafka. Bugs: KAFKA-1637

Re: Review Request 26710: Patch for KAFKA-1637

> On Oct. 15, 2014, 5:22 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 510 > > > > > > There is an issue here. The replica manager only contains information > > about partitions th

Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/#review56699 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/#review56662 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/#review56655 --- Ship it! Ship It! - Neha Narkhede On Oct. 14, 2014, 10:04 p.m.,