----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/#review56662 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/26710/#comment97067> There is an issue here. The replica manager only contains information about partitions that are assigned to this broker. However, some consumer group's offset manager may also be on this broker and that group may consume various partitions that are not assigned to this broker. The offset manager though will still contain offsets for those partitions. - Joel Koshy On Oct. 14, 2014, 10:04 p.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26710/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 10:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1637 > https://issues.apache.org/jira/browse/KAFKA-1637 > > > Repository: kafka > > > Description > ------- > > KAFKA-1637 Return correct error code and offsets for OffsetFetchRequest for > unknown topics/partitions vs no associated consumer. > > > Diffs > ----- > > core/src/main/scala/kafka/common/OffsetMetadataAndError.scala > 1586243d20d6a181a1bd9f07e1c9493596005b32 > core/src/main/scala/kafka/server/KafkaApis.scala > 67f2833804cb15976680e42b9dc49e275c89d266 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 2d9325045ac1ac2d7531161b32c98c847125cbf0 > > Diff: https://reviews.apache.org/r/26710/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >
