Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
> On Aug. 22, 2014, 10:39 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > > > > > Would it be simpler to just don't do the test on partError? The

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/ --- (Updated Aug. 22, 2014, 11:22 p.m.) Review request for kafka. Bugs: KAFKA-160

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51327 --- clients/src/main/java/org/apache/kafka/common/requests/MetadataResp

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51325 --- Ship it! Ship It! - Guozhang Wang On Aug. 22, 2014, 8:04 p.m., D

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
> On Aug. 22, 2014, 8:50 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > > > > > Is this possilbe that the reponse can also contain other e

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
> On Aug. 22, 2014, 8:56 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > > > > > Guozhang, an unknown topic would be captured at the topic-err

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51317 --- clients/src/main/java/org/apache/kafka/common/requests/MetadataResp

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51316 --- clients/src/main/java/org/apache/kafka/common/requests/MetadataResp

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/ --- (Updated Aug. 22, 2014, 8:04 p.m.) Review request for kafka. Bugs: KAFKA-1609

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/ --- (Updated Aug. 22, 2014, 8:02 p.m.) Review request for kafka. Bugs: KAFKA-1609