> On Aug. 22, 2014, 10:39 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > <https://reviews.apache.org/r/24992/diff/2/?file=667650#file667650line121> > > > > Would it be simpler to just don't do the test on partError? The rest of > > the code can deal with a null leader already. It's probably a bit weird to > > ignore a partition whose leader is not available. For example, if a message > > has to go to a partition (e.g., keyed message), we want to know that > > partition whether the leader is available or not.
Sure! The patch is updated. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51327 ----------------------------------------------------------- On Aug. 22, 2014, 11:22 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24992/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 11:22 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1609 > https://issues.apache.org/jira/browse/KAFKA-1609 > > > Repository: kafka > > > Description > ------- > > KAFKA-1609; New producer metadata response handling should not exclude a > PartitionInfo when there is partition error. > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java > 7d90fceffd4a92460c616f8bacd78057a38a3c16 > > Diff: https://reviews.apache.org/r/24992/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
