Re: Review Request 23440: Patch for KAFKA-1536

2014-08-06 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23440/ --- (Updated Aug. 6, 2014, 2:17 p.m.) Review request for kafka. Summary (updated)

Re: Review Request 23440: Patch for KAFKA-1536; addressing reviewer comments

2014-07-18 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23440/ --- (Updated July 18, 2014, 3:08 p.m.) Review request for kafka. Summary (updated

Re: Review Request 23440: Patch for KAFKA-1536

2014-07-17 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23440/#review48017 --- Other than the comment below, this patch looks great! kafka-patch-

Re: Review Request 23440: Patch for KAFKA-1536

2014-07-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23440/#review47688 --- Ship it! Local test works. - Guozhang Wang On July 12, 2014, 1:5