----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23440/#review48017 -----------------------------------------------------------
Other than the comment below, this patch looks great! kafka-patch-review.py <https://reviews.apache.org/r/23440/#comment84268> our naming convention is not really camel case in this python code. Could you change transitionsMap to jira_transitions? - Neha Narkhede On July 12, 2014, 1:51 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23440/ > ----------------------------------------------------------- > > (Updated July 12, 2014, 1:51 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1536 > https://issues.apache.org/jira/browse/KAFKA-1536 > > > Repository: kafka > > > Description > ------- > > JIRA status set to Patch Available in kafka-patch-review script > > > Diffs > ----- > > kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef > > Diff: https://reviews.apache.org/r/23440/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
