Re: Review Request 23266: Fix KAFKA-1515

2014-07-08 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/ --- (Updated July 8, 2014, 6:35 p.m.) Review request for kafka. Bugs: KAFKA-1515

RE: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
[nore...@reviews.apache.org] on behalf of Jay Kreps [boredandr...@gmail.com] Sent: Monday, July 07, 2014 1:45 PM To: Jay Kreps; kafka; Guozhang Wang Subject: Re: Review Request 23266: Fix KAFKA-1515 This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266

RE: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
Guozhang From: Guozhang Wang Sent: Monday, July 07, 2014 1:49 PM To: Jay Kreps; kafka Subject: RE: Review Request 23266: Fix KAFKA-1515 Jay, About 1), I just remembered why I did not use a while loop inside forceUpdate, which is because every time we are interrupted but not j

Re: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/ --- (Updated July 7, 2014, 9:17 p.m.) Review request for kafka. Bugs: KAFKA-1515

Re: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/#review47414 --- Three very minor issues: 1. It would be good to use a while loop whe

Re: Review Request 23266: Fix KAFKA-1515

2014-07-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/ --- (Updated July 7, 2014, 5:55 p.m.) Review request for kafka. Bugs: KAFKA-1515

Re: Review Request 23266: Fix KAFKA-1515

2014-07-03 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/#review47334 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

Re: Review Request 23266: Fix KAFKA-1515

2014-07-03 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/ --- (Updated July 3, 2014, 11:42 p.m.) Review request for kafka. Bugs: KAFKA-1515

Re: Review Request 23266: Fix KAFKA-1515

2014-07-03 Thread Guozhang Wang
> On July 3, 2014, 5:05 p.m., Jun Rao wrote: > > clients/src/test/resources/log4j.properties, lines 15-16 > > > > > > Are those changes intended? Nope they are not.. - Guozhang -

Re: Review Request 23266: Fix KAFKA-1515

2014-07-03 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/ --- (Updated July 3, 2014, 5:19 p.m.) Review request for kafka. Bugs: KAFKA-1515

Re: Review Request 23266: Fix KAFKA-1515

2014-07-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/#review47302 --- clients/src/test/resources/log4j.properties