> On July 3, 2014, 5:05 p.m., Jun Rao wrote: > > clients/src/test/resources/log4j.properties, lines 15-16 > > <https://reviews.apache.org/r/23266/diff/1/?file=623581#file623581line15> > > > > Are those changes intended?
Nope they are not.. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23266/#review47302 ----------------------------------------------------------- On July 3, 2014, 5:19 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23266/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 5:19 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1515 > https://issues.apache.org/jira/browse/KAFKA-1515 > > > Repository: kafka > > > Description > ------- > > 1. Move the waiting logic out of Metadata into KafkaProducer (KafkaConsumer > would not wait on fetch metadata, so will not share this code); and wake-up > sender upon waiting metadata 2. Set the refresh timestamp to now instead of 0 > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > d85ca30001dc3d6122a890c34092551654315458 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java > 8890aa2e3ce5fffc159b3c8528138226e8c8cfd3 > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java > 0d7d04ca5d71d4db22da54ed2153f7c0e10cdf78 > > Diff: https://reviews.apache.org/r/23266/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
