Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41071 --- Ship it! - Joel Koshy On April 22, 2014, 8:51 p.m., Jun Rao wrote

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41067 --- Ship it! Ship It! - Timothy Chen On April 22, 2014, 8:51 p.m., J

Re: Review Request 20540: Patch for KAFKA-1410

> On April 22, 2014, 12:07 a.m., Guozhang Wang wrote: > > This patch is much larger than it is claimed to be :) Any rebasing missed > > here? It picked up the remaining followup change in kafka-1356: basically moving the locking/live broker list inside MetadataCache. - Jun

Re: Review Request 20540: Patch for KAFKA-1410

> On April 22, 2014, 6:26 p.m., Timothy Chen wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 713 > > > > > > Do we no longer need to check for offset management topic? Good catch. Fixed. - Jun --

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/ --- (Updated April 22, 2014, 8:51 p.m.) Review request for kafka. Bugs: KAFKA-141

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41039 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/ --- (Updated April 22, 2014, 4:37 p.m.) Review request for kafka. Bugs: KAFKA-141

Re: Review Request 20540: Patch for KAFKA-1410

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review40980 --- This patch is much larger than it is claimed to be :) Any rebasing m