Re: Review Request 19831: Patch for KAFKA-1337

> On April 4, 2014, 8:36 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java, > > line 51 > > > > > > We also fetch metadata when there are topic changes or leader

Re: Review Request 19831: Patch for KAFKA-1337

> On April 4, 2014, 8:36 p.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java, > > line 51 > > > > > > We also fetch metadata when there are topic changes or leader

Re: Review Request 19831: Patch for KAFKA-1337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19831/#review39328 --- Ship it! Minor comments below that you can fix on checkin clients

Re: Review Request 19831: Patch for KAFKA-1337

> On April 1, 2014, 4:50 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java, > > lines 32-33 > > > > > > Is the java variable name part of the public API too? Yes, as

Re: Review Request 19831: Patch for KAFKA-1337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19831/#review39169 --- Could metadata.fetch.backoff.ms and retry.backoff.ms be merged into

Re: Review Request 19831: Patch for KAFKA-1337

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19831/#review39085 --- Ship it! With some general minor comments: 1. The systems tests ha