Re: Review Request 18846: Patch for KAFKA-1189

2014-03-06 Thread Neha Narkhede
> On March 6, 2014, 5:37 p.m., Jun Rao wrote: > > Could you test that works on both mac and linux? > > Martin Kleppmann wrote: > Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The > behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts > down correctly

Re: Review Request 18846: Patch for KAFKA-1189

2014-03-06 Thread Jun Rao
> On March 6, 2014, 5:37 p.m., Jun Rao wrote: > > Could you test that works on both mac and linux? > > Martin Kleppmann wrote: > Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The > behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts > down correctly

Re: Review Request 18846: Patch for KAFKA-1189

2014-03-06 Thread Neha Narkhede
> On March 6, 2014, 5:37 p.m., Jun Rao wrote: > > Could you test that works on both mac and linux? > > Martin Kleppmann wrote: > Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The > behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts > down correctly

Re: Review Request 18846: Patch for KAFKA-1189

2014-03-06 Thread Martin Kleppmann
> On March 6, 2014, 5:37 p.m., Jun Rao wrote: > > Could you test that works on both mac and linux? Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts down correctly on SIGTERM. - Martin

Re: Review Request 18846: Patch for KAFKA-1189

2014-03-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18846/#review36371 --- Could you test that works on both mac and linux? - Jun Rao On Mar

Re: Review Request 18846: Patch for KAFKA-1189

2014-03-06 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18846/#review36368 --- Ship it! Ship It! - Neha Narkhede On March 6, 2014, 3:26 p.m., M