> On March 6, 2014, 5:37 p.m., Jun Rao wrote: > > Could you test that works on both mac and linux? > > Martin Kleppmann wrote: > Jun: yes, I've tested both on Mac OS 10.8.5 and Ubuntu 12.04. The > behavior is the same on both: the nohup'ed process ignores SIGINT, but shuts > down correctly on SIGTERM. > > Neha Narkhede wrote: > Jun, I also gave this a swing on my Mac 10.8.5 and Linux RHEL and seemed > to work. Are you looking for any particular problem? > > Jun Rao wrote: > It's just that earlier there were people in the mailing list complaining > that our shutdown script doesn't work in one of the environments. If the fix > works in both, then I am +1.
Yes, the only question is Windows, which is an unknown. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18846/#review36371 ----------------------------------------------------------- On March 6, 2014, 3:26 p.m., Martin Kleppmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18846/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 3:26 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1189 > https://issues.apache.org/jira/browse/KAFKA-1189 > > > Repository: kafka > > > Description > ------- > > KAFKA-1189 use SIGTERM to shut down broker, as nohup swallows SIGINT > > > Diffs > ----- > > bin/kafka-server-stop.sh 35a26a6529a91e0e5b18c7a3e0357f9241b36721 > > Diff: https://reviews.apache.org/r/18846/diff/ > > > Testing > ------- > > > Thanks, > > Martin Kleppmann > >
