Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

> On March 2, 2014, 2:15 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > lines 155-157 > > > > > > My earlier comment about whether we should clos

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

> On March 2, 2014, 2:15 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java, > > lines 151-165 > > > > > > Shouldn't we set the limit for buffer to pos at the end so that

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review35910 --- Could we add a unit test that covers the case that the compressed me

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review35908 --- Could you rebase? clients/src/main/java/org/apache/kafka/clients/p

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 27, 2014, 1:33 a.m.) Review request for kafka. Bugs: KAFKA-1253

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 27, 2014, 1:31 a.m.) Review request for kafka. Bugs: KAFKA-1253

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

> On Feb. 25, 2014, 6:22 p.m., Jun Rao wrote: > > Could we extend ProducerSendTest to test sending/reading compressed > > messages? Yep > On Feb. 25, 2014, 6:22 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java, > > lines 72-73 > >

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review35422 --- Could we extend ProducerSendTest to test sending/reading compressed

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 24, 2014, 9:34 p.m.) Review request for kafka. Bugs: KAFKA-1253

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 24, 2014, 9:31 p.m.) Review request for kafka. Bugs: KAFKA-1253

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

> On Feb. 23, 2014, 10:38 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java, > > lines 101-112 > > > > > > This is actually not the right place to add the offse

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

> On Feb. 23, 2014, 10:38 p.m., Jun Rao wrote: > > A couple of high level comments: > > > > 1. RecordBatch: If compression is enabled in the producer, each Records > > will be of CompressedMemoryRecord. The tricky thing will be in tryAppend(). > > In the corner case, it could happen that the c

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review35245 --- A couple of high level comments: 1. RecordBatch: If compression is

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 22, 2014, 1:57 a.m.) Review request for kafka. Bugs: KAFKA-1253

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 22, 2014, 1:56 a.m.) Review request for kafka. Bugs: KAFKA-1253

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 22, 2014, 12:16 a.m.) Review request for kafka. Bugs: KAFKA-125

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated Feb. 22, 2014, 12:15 a.m.) Review request for kafka. Bugs: KAFKA-125

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review34977 --- clients/src/main/java/org/apache/kafka/common/record/CompressedMemo