----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review34977 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java <https://reviews.apache.org/r/18299/#comment65371> This should maybe be lazy? clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java <https://reviews.apache.org/r/18299/#comment65370> Writing the full record array is not actually correct. The ByteBuffer just represents a slice of the backing array so if you write the full backing array you may be writing other data. clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java <https://reviews.apache.org/r/18299/#comment65368> I don't think this will fly, we should refactor in some way to do the right in place. clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java <https://reviews.apache.org/r/18299/#comment65369> We should ideally do this with out double-copying. - Jay Kreps On Feb. 20, 2014, 2:58 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18299/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 2:58 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1253 > https://issues.apache.org/jira/browse/KAFKA-1253 > > > Repository: kafka > > > Description > ------- > > KAFKA-1253 > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/record/ByteBufferInputStream.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/record/ByteBufferOutputStream.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/record/CompressedMemoryRecords.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18299/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
