Re: Review Request 17918: Patch for KAFKA-1233

> On Feb. 11, 2014, 11:27 p.m., Jay Kreps wrote: > > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, line 283 > > > > > > It would be good to add a test where we send a message, stop one of the > > s

Re: Review Request 17918: Patch for KAFKA-1233

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17918/#review34241 --- core/src/test/scala/integration/kafka/api/ProducerSendTest.scala

Re: Review Request 17918: Patch for KAFKA-1233

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17918/#review34230 --- Ship it! Ship It! - Neha Narkhede On Feb. 11, 2014, 8:28 p.m., G

Re: Review Request 17918: Patch for KAFKA-1233

> On Feb. 11, 2014, 7:18 p.m., Neha Narkhede wrote: > > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, line 109 > > > > > > These 3 statements are repeated in many tests. Can we create a helper > >

Re: Review Request 17918: Patch for KAFKA-1233

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17918/ --- (Updated Feb. 11, 2014, 8:28 p.m.) Review request for kafka. Bugs: KAFKA-1233

Re: Review Request 17918: Patch for KAFKA-1233

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17918/ --- (Updated Feb. 11, 2014, 8:27 p.m.) Review request for kafka. Bugs: KAFKA-1233

Re: Review Request 17918: Patch for KAFKA-1233

> On Feb. 11, 2014, 7:18 p.m., Neha Narkhede wrote: > > core/src/test/resources/log4j.properties, line 15 > > > > > > this is probably included in the patch by accident right? Yeah, will fix. > On Feb. 11, 2014, 7:18

Re: Review Request 17918: Patch for KAFKA-1233

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17918/ --- (Updated Feb. 11, 2014, 7:24 p.m.) Review request for kafka. Summary (updated