> On Feb. 11, 2014, 11:27 p.m., Jay Kreps wrote:
> > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, line 283
> > <https://reviews.apache.org/r/17918/diff/3/?file=482894#file482894line283>
> >
> >     It would be good to add a test where we send a message, stop one of the 
> > servers, send another message (should fail) then send another message 
> > (should succeed going to the new leader).

This is happening in Part II, which is another JIRA :)


> On Feb. 11, 2014, 11:27 p.m., Jay Kreps wrote:
> > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, line 202
> > <https://reviews.apache.org/r/17918/diff/3/?file=482894#file482894line202>
> >
> >     This test is very complicated. I think it validates two things:
> >     1. Partitioning works as expected
> >     2. The contents of the log is what we expect
> >     
> >     I recommend we remove (1). It is better tested in the direct test of 
> > the Partitioner.

Actually it does not intend to check 2), it checks the content of the messages 
just to validate the behavior of the default partitioner (round-robin).


- Guozhang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17918/#review34241
-----------------------------------------------------------


On Feb. 11, 2014, 8:28 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17918/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 8:28 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1233
>     https://issues.apache.org/jira/browse/KAFKA-1233
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Four test cases included in Part I:
> 
> Incorporated Jay's comments.
> 
> Rebased on new commits.
> 
> 1. Send API, with null key/value/partitionId/topic tested, check returned 
> offset. Currently passed.
> 
> 2. All messages drained before close, also check that messages with the same 
> key go to the same partition. Currently broken after some new commits ...
> 
> 3. The default round robin partitioner, and the specified partition id is 
> respected. Currently broken with ack = -1. Filed KAFKA-1255.
> 
> 4. Send with auto-topic-creation. Currently passed.
> 
> 
> Diffs
> -----
> 
>   build.gradle d9d6e6a91e6f37c0247107b0655f58a2db9688cd 
>   core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 
> PRE-CREATION 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
> 500eeca2f95d901536b1363b8c4b485c4893179f 
> 
> Diff: https://reviews.apache.org/r/17918/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Reply via email to