Re: Review Request 15953: Patch for KAFKA-1134

2013-12-10 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/#review30152 --- Ship it! Ship It! - Neha Narkhede On Dec. 5, 2013, 7:13 p.m., Gu

Re: Review Request 15953: Patch for KAFKA-1134

2013-12-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/#review30057 --- core/src/main/scala/kafka/controller/PartitionStateMachine.scala

Re: Review Request 15953: Patch for KAFKA-1134

2013-12-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/#review30047 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15953: Patch for KAFKA-1134

2013-12-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/ --- (Updated Dec. 5, 2013, 7:13 p.m.) Review request for kafka. Bugs: KAFKA-1134

Re: Review Request 15953: Patch for KAFKA-1134

2013-12-02 Thread Guozhang Wang
> On Dec. 3, 2013, 1:30 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 235 > > > > > > it seems that onControllerFailover is already protected by the > > controllerLock

Re: Review Request 15953: Patch for KAFKA-1134

2013-12-02 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/#review29636 --- core/src/main/scala/kafka/controller/KafkaController.scala