----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/#review30047 -----------------------------------------------------------
core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/15953/#comment57553> Is this change supposed to be part of this patch? core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/15953/#comment57555> is this intended? This is required no? core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/15953/#comment57554> why is this required? - Neha Narkhede On Dec. 5, 2013, 7:13 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15953/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 7:13 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1134 > https://issues.apache.org/jira/browse/KAFKA-1134 > > > Repository: kafka > > > Description > ------- > > KAFKA-1134.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > beca460dfe0f4df5ccd7f6358e44cbe742d256e5 > core/src/main/scala/kafka/controller/KafkaController.scala > 3beaf75f8285c8b6146aced2fefda4234cf1d307 > core/src/main/scala/kafka/controller/PartitionStateMachine.scala > 829163afab99706f7a34408eda2504c8262e572e > > Diff: https://reviews.apache.org/r/15953/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
