Re: Review Request 15674: address review comments

2013-12-19 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review30456 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: Review Request 15674: address review comments

2013-12-16 Thread Jun Rao
> On Dec. 10, 2013, 1:27 a.m., Jay Kreps wrote: > > core/src/main/scala/kafka/log/LogManager.scala, line 366 > > > > > > Another alternative would just be to let the background flush fail and > > log it rather than sh

Re: Review Request 15674: address review comments

2013-12-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/ --- (Updated Dec. 16, 2013, 5:43 p.m.) Review request for kafka. Bugs: KAFKA-1074

Re: Review Request 15674: address review comments

2013-12-16 Thread Jun Rao
> On Dec. 5, 2013, 1:54 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 205 > > > > > > Are we going to have other checkDone implementations for this case? If > > not we could just

Re: Review Request 15674: address review comments

2013-12-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/ --- (Updated Dec. 16, 2013, 5:41 p.m.) Review request for kafka. Summary (updated