+1
On Wed, Jul 19, 2017 at 1:35 PM, Jay Kreps wrote:
> +1
>
> On Sat, May 27, 2017 at 11:04 AM, Gwen Shapira wrote:
>
> > Thanks Vahid,
> >
> > Do you mind if we leave the command-line out of scope for this?
> >
> > I can see why adding confirmations, options to bypass confirmations, etc
> > wo
+1
On Sat, May 27, 2017 at 11:04 AM, Gwen Shapira wrote:
> Thanks Vahid,
>
> Do you mind if we leave the command-line out of scope for this?
>
> I can see why adding confirmations, options to bypass confirmations, etc
> would be an improvement. However, I've seen no complaints about the current
>
> > From: Gwen Shapira
> > To: dev@kafka.apache.org, us...@kafka.apache.org
> > Date: 05/27/2017 11:04 AM
> > Subject:Re: KIP-162: Enable topic deletion by default
> >
> >
> >
> > Thanks Vahid,
> >
> > Do you min
So, perhaps a new follow-up JIRA to this KIP to add the confirmation for
> topic deletion.
>
> Thanks.
> --Vahid
>
>
>
> From: Gwen Shapira
> To: dev@kafka.apache.org, us...@kafka.apache.org
> Date: 05/27/2017 11:04 AM
> Subject:Re: KIP-162: Enabl
not reversible.
> So, perhaps a new follow-up JIRA to this KIP to add the confirmation for
> topic deletion.
>
> Thanks.
> --Vahid
>
>
>
> From: Gwen Shapira
> To: dev@kafka.apache.org, us...@kafka.apache.org
> Date: 05/27/2017 11:04 AM
> Subj
From: Gwen Shapira
To: dev@kafka.apache.org, us...@kafka.apache.org
Date: 05/27/2017 11:04 AM
Subject:Re: KIP-162: Enable topic deletion by default
Thanks Vahid,
Do you mind if we leave the command-line out of scope for this?
I can see why adding confirmations, options to
Agreed and updated the KIP accordingly. Thank you!
On Sat, May 27, 2017 at 1:25 AM Guozhang Wang wrote:
> I'd say just remove those two lines.
>
> On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira wrote:
>
> > This was a discussion, not a vote (sorry for mangling the title), but
> > thanks for all
Thanks Vahid,
Do you mind if we leave the command-line out of scope for this?
I can see why adding confirmations, options to bypass confirmations, etc
would be an improvement. However, I've seen no complaints about the current
behavior of the command-line and the KIP doesn't change it at all. So
This KIP only changes a configuration default, so the two changes seem
independent to me.
And since both changes will be included in the release following 0.11
(October) and no sooner, I don't know if the order matters that much.
Am I missing anything regarding KAFKA-4893 that means KIP-162 isn't
Would it make sense to resolve KAFKA-4893 before enabling it by default, as
fixing the ticket would likely involve changing the log directory structure?
On Fri, May 26, 2017 at 3:24 PM, Guozhang Wang wrote:
> I'd say just remove those two lines.
>
> On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira
I'd say just remove those two lines.
On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira wrote:
> This was a discussion, not a vote (sorry for mangling the title), but
> thanks for all the +1 anyway.
>
> Regarding Ismael's feedback:
> The current server.properties includes the following:
> # Switch to
> On May 26, 2017, at 1:10 PM, Vahid S Hashemian
> wrote:
>
> Gwen, thanks for the KIP.
> It looks good to me.
>
> Just a minor suggestion: It would be great if the command asks for a
> confirmation (y/n) before deleting the topic (similar to how removing ACLs
> works).
>
+1 (or some sort
Gwen, thanks for the KIP.
It looks good to me.
Just a minor suggestion: It would be great if the command asks for a
confirmation (y/n) before deleting the topic (similar to how removing ACLs
works).
Thanks.
--Vahid
From: Gwen Shapira
To: "dev@kafka.apache.org" , Users
Date: 05/26/
+1
On Fri, May 26, 2017 at 10:55 AM, Gwen Shapira wrote:
> This was a discussion, not a vote (sorry for mangling the title), but
> thanks for all the +1 anyway.
>
> Regarding Ismael's feedback:
> The current server.properties includes the following:
> # Switch to enable topic deletion or not, de
This was a discussion, not a vote (sorry for mangling the title), but
thanks for all the +1 anyway.
Regarding Ismael's feedback:
The current server.properties includes the following:
# Switch to enable topic deletion or not, default value is false
#delete.topic.enable=true
We can't leave it as is
+1 (non-binding)
On Fri, May 26, 2017 at 3:38 PM, Damian Guy wrote:
> +1
> Also agree with what Ismael said.
>
> On Fri, 26 May 2017 at 15:26 Ismael Juma wrote:
>
> > Thanks for the KIP, sounds good to me. One comment: not sure we need to
> add
> > the config to server.properties. Do we expect
+1
Also agree with what Ismael said.
On Fri, 26 May 2017 at 15:26 Ismael Juma wrote:
> Thanks for the KIP, sounds good to me. One comment: not sure we need to add
> the config to server.properties. Do we expect people to change this
> default?
>
> On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira w
Thanks for the KIP, sounds good to me. One comment: not sure we need to add
the config to server.properties. Do we expect people to change this default?
On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira wrote:
> Hi Kafka developers, users and friends,
>
> I've added a KIP to improve our out-of-the-b
+1
El vie., 26 may. 2017 a las 16:14, Matthias J. Sax ()
escribió:
> +1
>
> On 5/26/17 7:03 AM, Gwen Shapira wrote:
> > Hi Kafka developers, users and friends,
> >
> > I've added a KIP to improve our out-of-the-box usability a bit:
> > KIP-162: Enable topic deletion by default:
> >
> https://cwik
+1
On 5/26/17 7:03 AM, Gwen Shapira wrote:
> Hi Kafka developers, users and friends,
>
> I've added a KIP to improve our out-of-the-box usability a bit:
> KIP-162: Enable topic deletion by default:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default
>
>
20 matches
Mail list logo
