This KIP only changes a configuration default, so the two changes seem independent to me.
And since both changes will be included in the release following 0.11 (October) and no sooner, I don't know if the order matters that much. Am I missing anything regarding KAFKA-4893 that means KIP-162 isn't as simple as I assume? Gwen On Sat, May 27, 2017 at 4:25 AM Onur Karaman <onurkaraman.apa...@gmail.com> wrote: > Would it make sense to resolve KAFKA-4893 before enabling it by default, as > fixing the ticket would likely involve changing the log directory > structure? > > On Fri, May 26, 2017 at 3:24 PM, Guozhang Wang <wangg...@gmail.com> wrote: > > > I'd say just remove those two lines. > > > > On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira <g...@confluent.io> wrote: > > > > > This was a discussion, not a vote (sorry for mangling the title), but > > > thanks for all the +1 anyway. > > > > > > Regarding Ismael's feedback: > > > The current server.properties includes the following: > > > # Switch to enable topic deletion or not, default value is false > > > #delete.topic.enable=true > > > > > > We can't leave it as is, obviously - since the KIP invalidates the > > > comment. Lets just remove those two lines? > > > > > > Note that all our proposed changes may break few community > puppet/docker > > > scripts that use these lines for "sed" that enables topic deletion. > > > > > > Gwen > > > > > > On Fri, May 26, 2017 at 5:41 PM Tom Crayford <tcrayf...@heroku.com> > > wrote: > > > > > > > +1 (non-binding) > > > > > > > > On Fri, May 26, 2017 at 3:38 PM, Damian Guy <damian....@gmail.com> > > > wrote: > > > > > > > > > +1 > > > > > Also agree with what Ismael said. > > > > > > > > > > On Fri, 26 May 2017 at 15:26 Ismael Juma <ism...@juma.me.uk> > wrote: > > > > > > > > > > > Thanks for the KIP, sounds good to me. One comment: not sure we > > need > > > to > > > > > add > > > > > > the config to server.properties. Do we expect people to change > this > > > > > > default? > > > > > > > > > > > > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira <g...@confluent.io > > > > > > wrote: > > > > > > > > > > > > > Hi Kafka developers, users and friends, > > > > > > > > > > > > > > I've added a KIP to improve our out-of-the-box usability a bit: > > > > > > > KIP-162: Enable topic deletion by default: > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+ > > > > > > > Enable+topic+deletion+by+default > > > > > > > > > > > > > > Pretty simple :) Discussion and feedback are welcome. > > > > > > > > > > > > > > Gwen > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > -- Guozhang > > >
