Re: Build hanging

2024-06-07 Thread Apoorv Mittal
Hi Sophie, Yes the PR should also fix the tests in other class you mentioned. I have validated locally and attached details in the PR for successful run on local. - Regards, Apoorv Mittal > On 8 Jun 2024, at 02:24, Sophie Blee-Goldman wrote: > > Thanks for the quick fix! > > By the way, I to

Re: Build hanging

2024-06-07 Thread Sophie Blee-Goldman
Thanks for the quick fix! By the way, I took a quick look at the output for some aborted builds and can confirm that this test is also hanging: SaslClientsWithInvalidCre dentialsTest.testKafkaAdminClientWithAuthenticationFailure It sounds like it probably has the same root cause as the test we al

Re: Build hanging

2024-06-07 Thread Haruki Okada
Oh, thank you for identifying the root cause quickly Apoorv. I changed the assignee of KAFKA-16916 to you. Thanks, 2024年6月8日(土) 10:13 Apoorv Mittal : > Hi, > Please find the fix for the issue: > https://github.com/apache/kafka/pull/16249 > > Regards, > Apoorv Mittal > +44 7721681581 > > > On S

Re: Build hanging

2024-06-07 Thread Apoorv Mittal
Hi, Please find the fix for the issue: https://github.com/apache/kafka/pull/16249 Regards, Apoorv Mittal +44 7721681581 On Sat, Jun 8, 2024 at 2:09 AM Sophie Blee-Goldman wrote: > Thanks for jumping on this guys, and nice find Haruki > > I agree with Luke that we should disable the offending t

Re: Build hanging

2024-06-07 Thread Sophie Blee-Goldman
Thanks for jumping on this guys, and nice find Haruki I agree with Luke that we should disable the offending tests ASAP to unblock other things, and file a 3.8 blocker to investigate this further. Thanks for the PR Haruki and thanks for filing the ticket Luke -- I marked it as a blocker for 3.8.0

Re: Build hanging

2024-06-07 Thread Haruki Okada
Opened the PR h(ttps://github.com/apache/kafka/pull/16248) Let's see if CI runs properly. Thanks, 2024年6月8日(土) 10:01 Luke Chen : > > Let's disable for now to unblock builds, and revert later if we can't > solve > it until code freeze? > > That's exactly what I meant to do. > I've opened KAFKA-16

Re: Build hanging

2024-06-07 Thread Luke Chen
> Let's disable for now to unblock builds, and revert later if we can't solve it until code freeze? That's exactly what I meant to do. I've opened KAFKA-16916 for this issue and assigned to you. Welcome to unassign yourselves if you don't have ti

Re: Build hanging

2024-06-07 Thread Haruki Okada
Hi Luke, I see, but since this is likely due to AdminClient's behavior change, we need to fix it anyways not only disabling test before 3.8 release. Let's disable for now to unblock builds, and revert later if we can't solve it until code freeze? 2024年6月8日(土) 9:31 Luke Chen : > Hi Haruki, > > Th

Re: Build hanging

2024-06-07 Thread Luke Chen
Hi Haruki, Thanks for identifying this blocking test. Could you help quickly open a PR to disable this test to unblock the CI build? Thanks. Luke On Sat, Jun 8, 2024 at 8:20 AM Haruki Okada wrote: > Hi > > I found that the hanging can be reproduced locally. > The blocking test is > > "org.apac

Re: Build hanging

2024-06-07 Thread Haruki Okada
Hi I found that the hanging can be reproduced locally. The blocking test is "org.apache.kafka.common.security.authenticator.ClientAuthenticationFailureTest.testAdminClientWithInvalidCredentials". It started to block after this commit ( https://github.com/apache/kafka/commit/c01279b92acefd913508958