Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-27 Thread Beyene, Mehari
Hi all, I would like thank you all of you for participating in the voting process. After being open for 11 days, we have received the necessary votes to proceed, and I am now closing the voting process. KIP-937 has been accepted with 3 binding votes from Luke Chen, Divij Vaidya, and Justine Ols

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-27 Thread Justine Olshan
Hey Mehari, Yes. The KIP looks good to me. +1 (binding) Justine On Tue, Jun 27, 2023 at 12:13 PM Beyene, Mehari wrote: > Hi Justine/All, > > I want to wrap up this voting process in the next day or so. Justine, > since you gave a conditional binding vote regarding updating the error > message,

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-27 Thread Beyene, Mehari
Hi Justine/All, I want to wrap up this voting process in the next day or so. Justine, since you gave a conditional binding vote regarding updating the error message, I want to circle back and verify that you're happy with the current state of the changes before concluding the voting process. T

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-27 Thread Christo Lolov
+1 (non-binding) from me as well! This is the type of problem which is difficult to become aware of so the more guardrails we put into place the better. On Wed, 21 Jun 2023 at 23:30, Beyene, Mehari wrote: > Thank you, Justin. That makes sense. > I have updated the KIP to remove the concept of ah

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-21 Thread Beyene, Mehari
Thank you, Justin. That makes sense. I have updated the KIP to remove the concept of ahead/behind. Instead, we will use the existing error message that utilizes the acceptable range for the timestamps. Thanks, Mehari

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-21 Thread Justine Olshan
Hey Mehari, Thanks for the KIP. One minor change is now that we have the before and after configs does this error make sense? > we will return error code 32 (INVALID_TIMESTAMP) with the error message "Timestamp of the message with offset [record offset] is ahead of the broker's current time." I

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-20 Thread Andrew Schofield
+1 (non-binding). Thanks, Andrew > On 19 Jun 2023, at 11:42, Divij Vaidya wrote: > > This KIP solves a real operational pain point for the administrator of > Kafka cluster. > > +1 (binding) > > -- > Divij Vaidya > > > > On Sun, Jun 18, 2023 at 5:09 AM Kirk True wrote: > >> +1 (non-binding) >> >

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-17 Thread Kirk True
+1 (non-binding) Thanks Mehari! > On Jun 16, 2023, at 6:29 PM, Luke Chen wrote: > > +1 (binding) from me. > > Thanks. > Luke > > On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari > wrote: > >> Hello everyone, >> >> I am opening the Volte on KIP-937 here. If we have more to discuss, please >>

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-16 Thread Luke Chen
+1 (binding) from me. Thanks. Luke On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari wrote: > Hello everyone, > > I am opening the Volte on KIP-937 here. If we have more to discuss, please > continue the discussion on the existing thread at: > https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdl