Hey Mehari, Thanks for the KIP. One minor change is now that we have the before and after configs does this error make sense?
> we will return error code 32 (INVALID_TIMESTAMP) with the error message "Timestamp of the message with offset [record offset] is ahead of the broker's current time." I think maybe we should either say ahead/behind, or remove that aspect of the message. Other than that, the change seems reasonable. Given a clearer error, +1 from me (binding) Thanks, Justine On Tue, Jun 20, 2023 at 1:28 AM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > +1 (non-binding). > > Thanks, > Andrew > > > On 19 Jun 2023, at 11:42, Divij Vaidya <divijvaidy...@gmail.com> wrote: > > > > This KIP solves a real operational pain point for the administrator of > > Kafka cluster. > > > > +1 (binding) > > > > -- > > Divij Vaidya > > > > > > > > On Sun, Jun 18, 2023 at 5:09 AM Kirk True <k...@kirktrue.pro> wrote: > > > >> +1 (non-binding) > >> > >> Thanks Mehari! > >> > >>> On Jun 16, 2023, at 6:29 PM, Luke Chen <show...@gmail.com> wrote: > >>> > >>> +1 (binding) from me. > >>> > >>> Thanks. > >>> Luke > >>> > >>> On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari > >> <meh...@amazon.com.invalid> > >>> wrote: > >>> > >>>> Hello everyone, > >>>> > >>>> I am opening the Volte on KIP-937 here. If we have more to discuss, > >> please > >>>> continue the discussion on the existing thread at: > >>>> https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdlx3kc1g5zczc > >>>> > >>>> Thank you, > >>>> Mehari > >>>> > >>>> > >> > >> > >
