+1 from myself as well.
Folks, thanks for all the votes. I'm closing this ticket now with three
biding votes (Damian, Matthas, Guozhang) and one non-binding votes (Bill).
Guozhang
On Thu, Jan 24, 2019 at 2:53 PM Matthias J. Sax
wrote:
> +1 (binding)
>
> -Matthias
>
> On 1/24/19 8:23 AM, Damia
+1 (binding)
-Matthias
On 1/24/19 8:23 AM, Damian Guy wrote:
> +1
>
> On Wed, 23 Jan 2019 at 23:23, Guozhang Wang wrote:
>
>> Hello Matthias,
>>
>> Cool. I'd add it to the wiki page as well.
>>
>>
>> Guozhang
>>
>> On Sat, Jan 19, 2019 at 10:59 AM Matthias J. Sax
>> wrote:
>>
>>> Thanks for t
+1
On Wed, 23 Jan 2019 at 23:23, Guozhang Wang wrote:
> Hello Matthias,
>
> Cool. I'd add it to the wiki page as well.
>
>
> Guozhang
>
> On Sat, Jan 19, 2019 at 10:59 AM Matthias J. Sax
> wrote:
>
> > Thanks for the KIP Guozhang!
> >
> > Would it make sense to add a default implementation for
Hello Matthias,
Cool. I'd add it to the wiki page as well.
Guozhang
On Sat, Jan 19, 2019 at 10:59 AM Matthias J. Sax
wrote:
> Thanks for the KIP Guozhang!
>
> Would it make sense to add a default implementation for the new method?
> I am not sure, and I actually think it would not make sense:
Thanks for the KIP Guozhang, +1 for me.
-Bill
On Sat, Jan 19, 2019 at 1:59 PM Matthias J. Sax
wrote:
> Thanks for the KIP Guozhang!
>
> Would it make sense to add a default implementation for the new method?
> I am not sure, and I actually think it would not make sense:
>
> - Kafka Streams pro
Thanks for the KIP Guozhang!
Would it make sense to add a default implementation for the new method?
I am not sure, and I actually think it would not make sense:
- Kafka Streams provided stores will implement the method anyway
- Kafka Streams relies on a proper implementation for custom stores
Hi Boyang,
Thanks for the feedback!
Although its direct result is a bug fix, it still changes the public apis.
And we cannot enlarge the scope of a vote / adopted KIP that has been taken
place in a previous release, so I think it is worthwhile with a new one.
Guozhang
On Fri, Jan 18, 2019 at 1
Hey Guozhang,
this is nice catch! One question I have is that this seems more like a bug fix
than a new feature proposal, maybe we could just update KIP-261 interface and
resolve the JIRA to track the change?
Boyang
From: Guozhang Wang
Sent: Saturday, January