Thanks for the KIP Guozhang, +1 for me. -Bill
On Sat, Jan 19, 2019 at 1:59 PM Matthias J. Sax <matth...@confluent.io> wrote: > Thanks for the KIP Guozhang! > > Would it make sense to add a default implementation for the new method? > I am not sure, and I actually think it would not make sense: > > - Kafka Streams provided stores will implement the method anyway > - Kafka Streams relies on a proper implementation for custom stores > (because the new method in used during flush()). > > Thus, it seems that not adding a default implementation and hitting a > compilation error is better than hitting a runtime error later. > > However, I think it's worth to mention this on the KIP (ie, why not to > add a default implementation). > > > -Matthias > > On 1/18/19 10:33 PM, Guozhang Wang wrote: > > Hi Boyang, > > > > Thanks for the feedback! > > > > Although its direct result is a bug fix, it still changes the public > apis. > > And we cannot enlarge the scope of a vote / adopted KIP that has been > taken > > place in a previous release, so I think it is worthwhile with a new one. > > > > > > Guozhang > > > > On Fri, Jan 18, 2019 at 10:14 PM Boyang Chen <bche...@outlook.com> > wrote: > > > >> Hey Guozhang, > >> > >> this is nice catch! One question I have is that this seems more like a > bug > >> fix than a new feature proposal, maybe we could just update KIP-261 > >> interface and resolve the JIRA to track the change? > >> > >> Boyang > >> > >> ________________________________ > >> From: Guozhang Wang <wangg...@gmail.com> > >> Sent: Saturday, January 19, 2019 1:07 PM > >> To: dev > >> Subject: [VOTE] KIP-420: Add Single Value Fetch in Session Stores > >> > >> Hello folks, > >> > >> I'd like to calling for a last-minute vote on the following KIP: > >> > >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-420%3A+Add+Single+Value+Fetch+in+Session+Stores > >> > >> The idea comes from debugging a long lurking bug, but as an > afterthought I > >> think it should be included long time ago when we did KIP-261 [1]. > >> > >> [1] > >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-261%3A+Add+Single+Value+Fetch+in+Window+Stores > >> > >> > >> -- > >> -- Guozhang > >> > > > > > >
