In process of implementation of this KIP we discussed with John Roesler and
Matthias J. Sax two additional changes:
1. Changes in KafkaStream#close semantics [1] :
* reject negative numbers
* make 0 just signal and return immediately (after checking the state
once)
2. Default i
Hello, John
I responded in discussion thread.
I'm +1 for your proposal.
В Вт, 09/10/2018 в 13:05 -0500, John Roesler пишет:
> Hi Nikolay,
>
> I have a proposal to improve the compatibility around your KIP... Do you
> mind taking a look?
>
> https://github.com/apache/kafka/pull/5759#issuecommen
Hi Nikolay,
I have a proposal to improve the compatibility around your KIP... Do you
mind taking a look?
https://github.com/apache/kafka/pull/5759#issuecomment-428242210
Thanks,
-John
On Mon, Sep 24, 2018 at 3:44 PM Nikolay Izhikov wrote:
> Hello, John.
>
> Tests in my PR is green now.
> Plea
Hello, John.
Tests in my PR is green now.
Please, do the review.
https://github.com/apache/kafka/pull/5682
В Пн, 24/09/2018 в 20:36 +0300, Nikolay Izhikov пишет:
> Hello, John.
>
> Thank you.
>
> There are failing tests in my PR.
> I'm fixing them wright now.
>
> Will mail you in a next few h
Hello, John.
Thank you.
There are failing tests in my PR.
I'm fixing them wright now.
Will mail you in a next few hours, after all tests become green again.
В Пн, 24/09/2018 в 11:46 -0500, John Roesler пишет:
> Hi Nikolay,
>
> Thanks for the PR. I will review it.
>
> -John
>
> On Sat, Sep 22
Hi Nikolay,
Thanks for the PR. I will review it.
-John
On Sat, Sep 22, 2018 at 2:36 AM Nikolay Izhikov wrote:
> Hello
>
> I've opened a PR [1] for this KIP.
>
> [1] https://github.com/apache/kafka/pull/5682
>
> John, can you take a look?
>
> В Пн, 17/09/2018 в 20:16 +0300, Nikolay Izhikov пише
Hello
I've opened a PR [1] for this KIP.
[1] https://github.com/apache/kafka/pull/5682
John, can you take a look?
В Пн, 17/09/2018 в 20:16 +0300, Nikolay Izhikov пишет:
> John,
>
> Got it.
>
> Will do my best to meet this deadline.
>
> В Пн, 17/09/2018 в 11:52 -0500, John Roesler пишет:
> >
John,
Got it.
Will do my best to meet this deadline.
В Пн, 17/09/2018 в 11:52 -0500, John Roesler пишет:
> Yay! Thanks so much for sticking with this Nikolay.
>
> I look forward to your PR!
>
> Not to put pressure on you, but just to let you know, the deadline for
> getting your pr *merged* f
Yay! Thanks so much for sticking with this Nikolay.
I look forward to your PR!
Not to put pressure on you, but just to let you know, the deadline for
getting your pr *merged* for 2.1 is _October 1st_,
so you basically have 2 weeks to send the PR, have the reviews, and get it
merged.
(see
https:/
This KIP is now accepted with:
- 3 binding +1
- 2 non binding +1
Thanks, all.
Especially, John, Matthias, Guozhang, Bill, Damian!
В Чт, 13/09/2018 в 22:16 -0700, Guozhang Wang пишет:
> +1 (binding), thank you Nikolay!
>
> Guozhang
>
> On Thu, Sep 13, 2018 at 9:39 AM, Matthias J. Sax
> wrote:
+1 (binding), thank you Nikolay!
Guozhang
On Thu, Sep 13, 2018 at 9:39 AM, Matthias J. Sax
wrote:
> Thanks for the KIP.
>
> +1 (binding)
>
>
> -Matthias
>
> On 9/5/18 8:52 AM, John Roesler wrote:
> > I'm a +1 (non-binding)
> >
> > On Mon, Sep 3, 2018 at 8:33 AM Nikolay Izhikov
> wrote:
> >
> >
Thanks for the KIP.
+1 (binding)
-Matthias
On 9/5/18 8:52 AM, John Roesler wrote:
> I'm a +1 (non-binding)
>
> On Mon, Sep 3, 2018 at 8:33 AM Nikolay Izhikov wrote:
>
>> Dear commiters.
>>
>> Please, vote on a KIP.
>>
>> В Пт, 31/08/2018 в 12:05 -0500, John Roesler пишет:
>>> Hi Nikolay,
>>>
I'm a +1 (non-binding)
On Mon, Sep 3, 2018 at 8:33 AM Nikolay Izhikov wrote:
> Dear commiters.
>
> Please, vote on a KIP.
>
> В Пт, 31/08/2018 в 12:05 -0500, John Roesler пишет:
> > Hi Nikolay,
> >
> > You can start a PR any time, but we cannot per it (and probably won't do
> > serious reviews)
Dear commiters.
Please, vote on a KIP.
В Пт, 31/08/2018 в 12:05 -0500, John Roesler пишет:
> Hi Nikolay,
>
> You can start a PR any time, but we cannot per it (and probably won't do
> serious reviews) until after the KIP is voted and approved.
>
> Sometimes people start a PR during discussion j
Hi Nikolay,
You can start a PR any time, but we cannot per it (and probably won't do
serious reviews) until after the KIP is voted and approved.
Sometimes people start a PR during discussion just to help provide more
context, but it's not required (and can also be distracting because the KIP
disc
Hi Nickolay,
Thanks for the clarification.
-Bill
On Fri, Aug 31, 2018 at 11:59 AM Nikolay Izhikov
wrote:
> Hello, John.
>
> This is my first KIP, so, please, help me with kafka development process.
>
> Should I start to work on PR now? Or should I wait for a "+1" from
> commiters?
>
> В Пт, 31
Hello, John.
This is my first KIP, so, please, help me with kafka development process.
Should I start to work on PR now? Or should I wait for a "+1" from commiters?
В Пт, 31/08/2018 в 10:33 -0500, John Roesler пишет:
> I see. I guess that once we are in the PR-reviewing phase, we'll be in a
> be
I see. I guess that once we are in the PR-reviewing phase, we'll be in a
better position to see what else can/should be done, and we can talk about
follow-on work at that time.
Thanks for the clarification,
-John
On Fri, Aug 31, 2018 at 1:19 AM Nikolay Izhikov wrote:
> Hello, Bill
>
> > In the
Hello, Bill
> In the "Proposed Changes" section, there is "Try to reduce the visibility of
> methods in next tickets" does that mean eventual deprecation and removal?
1. Some methods will become deprecated. I think they will be removed in the
future.
You can find list of deprecated methods in K
Sorry for chiming in late, there was a lot of detail to catch up on.
Overall I'm +1 in the KIP. But I do have one question about the KIP in
regards to Matthias's comments about defining dual use.
In the "Proposed Changes" section, there is "Try to reduce the visibility
of methods in next tickets
John, thank you.
I've updated KIP.
Dear commiters, please take a look and share your opinion.
В Чт, 30/08/2018 в 14:58 -0500, John Roesler пишет:
> Oh! I missed one minor thing: UnlimitedWindows doesn't need to set grace
> (it currently does not either).
>
> Otherwise, it looks good to me!
>
Oh! I missed one minor thing: UnlimitedWindows doesn't need to set grace
(it currently does not either).
Otherwise, it looks good to me!
Thanks so much,
-John
On Thu, Aug 30, 2018 at 5:30 AM Nikolay Izhikov wrote:
> Hello, John.
>
> I've updated KIP according on your comments.
> Please, take a
Hello, John.
I've updated KIP according on your comments.
Please, take a look.
Are we ready to vot now?
В Ср, 29/08/2018 в 14:51 -0500, John Roesler пишет:
> Hey Nikolay, sorry for the silence. I'm taking another look at the KIP
> before voting...
>
>
>1. I think the Window constructor sho
Hey Nikolay, sorry for the silence. I'm taking another look at the KIP
before voting...
1. I think the Window constructor should actually be protected. I don't
know if we need a constructor that takes Instant, but if we do add one, it
should definitely be protected.
2. `long JoinWindo
24 matches
Mail list logo
