Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-29 Thread Yishun Guan
Sure, now we have 5 binding +1 votes and 2 non-biding +1 votes. Since we have more than three binding votes and no -1 votes, I guess KIP-324 is accepted? If so, I will then update the PR and the wiki. P.S. Guozhang, is this still needs to be worked on? https://issues.apache.org/jira/browse/KAFKA-6

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-29 Thread Guozhang Wang
Yes, please feel free to conclude this thread with a tally. Guozhang On Fri, Jun 29, 2018 at 11:53 AM Yishun Guan wrote: > Hi All, > > Since it has been 72 hrs. Should we go ahead and accept this KIP? Thanks. > > Best > Yishun > > On Wed, Jun 27, 2018, 4:14 PM Yishun Guan wrote: > > > I see!

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-29 Thread Yishun Guan
Hi All, Since it has been 72 hrs. Should we go ahead and accept this KIP? Thanks. Best Yishun On Wed, Jun 27, 2018, 4:14 PM Yishun Guan wrote: > I see! Thanks. -Yishun > > On Wed, Jun 27, 2018, 4:10 PM Guozhang Wang wrote: > >> Hi Yishun, >> >> We need to wait at least 72 business hours with

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Yishun Guan
I see! Thanks. -Yishun On Wed, Jun 27, 2018, 4:10 PM Guozhang Wang wrote: > Hi Yishun, > > We need to wait at least 72 business hours with three binding votes, > although you already have enough votes (me, Matthias, Damian) we still need > to wait enough hours for people to take a look and see i

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Guozhang Wang
Hi Yishun, We need to wait at least 72 business hours with three binding votes, although you already have enough votes (me, Matthias, Damian) we still need to wait enough hours for people to take a look and see if they have any different opinions. After 72 hours have passed since you started the

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Yishun Guan
Added! Thank you Colin. Do we now have enough votes? I read the bylaws and still a little bit confused. Thanks. - Yishun On Wed, Jun 27, 2018 at 3:24 PM, Colin McCabe wrote: > P.S. +1 (non-binding) once you add the info about it being thread-safe. > > best, > > > On Wed, Jun 27, 2018, at 15:23,

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Colin McCabe
P.S. +1 (non-binding) once you add the info about it being thread-safe. best, On Wed, Jun 27, 2018, at 15:23, Colin McCabe wrote: > On Tue, Jun 26, 2018, at 13:24, Yishun Guan wrote: > > Hi Colin, > > > > I agree with what Guozhang's opinion that because all the other clients > > have it (prod

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Colin McCabe
On Tue, Jun 26, 2018, at 13:24, Yishun Guan wrote: > Hi Colin, > > I agree with what Guozhang's opinion that because all the other clients > have it (producer, consumer..) and this will gain more visibility for those > application that use admin client. (Now I added this sentence to the KIP) I ag

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Harsha
+1 (binding) Thanks, Harsha On Wed, Jun 27th, 2018 at 10:56 AM, Damian Guy wrote: > > > > +1 (binding) > > Thanks > > > > On Wed, 27 Jun 2018 at 18:50 Bill Bejeck < bbej...@gmail.com > wrote: > > > +1 > > > > -Bill > > > > On Wed, Jun 27, 2018 at 12:47 PM Manikumar < manikumar.re...@gma

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Damian Guy
+1 (binding) Thanks On Wed, 27 Jun 2018 at 18:50 Bill Bejeck wrote: > +1 > > -Bill > > On Wed, Jun 27, 2018 at 12:47 PM Manikumar > wrote: > > > +1 (non-binding) > > > > Thanks. > > > > On Wed, Jun 27, 2018 at 10:15 PM Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > On 6/26/18 2

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Bill Bejeck
+1 -Bill On Wed, Jun 27, 2018 at 12:47 PM Manikumar wrote: > +1 (non-binding) > > Thanks. > > On Wed, Jun 27, 2018 at 10:15 PM Matthias J. Sax > wrote: > > > +1 (binding) > > > > On 6/26/18 2:33 PM, Guozhang Wang wrote: > > > +1. Thanks. > > > > > > On Tue, Jun 26, 2018 at 2:31 PM, Yishun Guan

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Manikumar
+1 (non-binding) Thanks. On Wed, Jun 27, 2018 at 10:15 PM Matthias J. Sax wrote: > +1 (binding) > > On 6/26/18 2:33 PM, Guozhang Wang wrote: > > +1. Thanks. > > > > On Tue, Jun 26, 2018 at 2:31 PM, Yishun Guan wrote: > > > >> Hi All, > >> > >> I am starting a vote on this KIP: > >> > >> https:

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-27 Thread Matthias J. Sax
+1 (binding) On 6/26/18 2:33 PM, Guozhang Wang wrote: > +1. Thanks. > > On Tue, Jun 26, 2018 at 2:31 PM, Yishun Guan wrote: > >> Hi All, >> >> I am starting a vote on this KIP: >> >> https://cwiki.apache.org/confluence/x/lQg0BQ >> >> Thanks, >> Yishun >> > > > signature.asc Description: O

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-26 Thread Guozhang Wang
+1. Thanks. On Tue, Jun 26, 2018 at 2:31 PM, Yishun Guan wrote: > Hi All, > > I am starting a vote on this KIP: > > https://cwiki.apache.org/confluence/x/lQg0BQ > > Thanks, > Yishun > -- -- Guozhang

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-26 Thread Yishun Guan
Hi Colin, I agree with what Guozhang's opinion that because all the other clients have it (producer, consumer..) and this will gain more visibility for those application that use admin client. (Now I added this sentence to the KIP) Since this returns an unmodifiableMap(like all the other client's

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

2018-06-26 Thread Colin McCabe
Can you add a little more explanation to the KIP for why you are adding this method? Is it something streams needs, for example? Will it help other applications that use admin client and want to expose metrics? What are the thread-safety guarantees for the map which is returned? best, Colin