P.S. +1 (non-binding) once you add the info about it being thread-safe. best,
On Wed, Jun 27, 2018, at 15:23, Colin McCabe wrote: > On Tue, Jun 26, 2018, at 13:24, Yishun Guan wrote: > > Hi Colin, > > > > I agree with what Guozhang's opinion that because all the other clients > > have it (producer, consumer..) and this will gain more visibility for those > > application that use admin client. (Now I added this sentence to the KIP) > > I agree. Thanks. > > > Since this returns an unmodifiableMap(like all the other client's metrics() > > return), I assume this will be thread-safe, what do you think? > > Please document that it is thread-safe. > > thanks, > Colin > > > > > Thanks, > > Yishun > > > > > > On Tue, Jun 26, 2018 at 11:51 AM, Colin McCabe <cmcc...@apache.org> wrote: > > > > > Can you add a little more explanation to the KIP for why you are adding > > > this method? Is it something streams needs, for example? Will it help > > > other applications that use admin client and want to expose metrics? > > > > > > What are the thread-safety guarantees for the map which is returned? > > > > > > best, > > > Colin > > > > > > > > > On Tue, Jun 26, 2018, at 11:29, Yishun Guan wrote: > > > > Hi All, > > > > > > > > I am starting a vote on this KIP: > > > > > > > > https://cwiki.apache.org/confluence/x/lQg0BQ > > > > > > > > Thanks, > > > > Yishun > > >
